-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lagoon-core appVersion v2.18.0 #647
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the fill-test-ci-values target's dependency on install-registry was correctly manipulated by the SKIP_INSTALL_REGISTRY variable, the install-lagoon-build-deploy target had a hard-coded dependency on install-registry. The result was that the registry would get installed multiple times anyway via the fill-test-ci-values target via an indirect dependency. Fix that by removing the dependency that install-lagoon-build-deploy has on install-registry when SKIP_INSTALL_REGISTRY=true.
fix: avoid installing the registry multiple times
chore: modify keycloak healthcheck endpoint for newer keycloak
Set 1.28 as default for tests, also test 1.29
chore: remove dioscuri subchart from lagoon-remote
Support Keycloak migrations via the API init-container
feat: add log streaming option to ssh-portal
To resolve a weird proxy issue with ui/keycloak http 502s when running lagoon in k3d and testing ui functionality, can the core
|
Using `localhost` and port `3306` forces mysqladmin to connect to `127.0.0.1` via TCP, instead of via socket. The uselagoon/mariadb images only set a root password for `localhost`, so the attempt to authenticate via `127.0.0.1` fails.
The current TCP based readiness probe causes an `Aborted connection` log for each check. Changing it to the `readiness-probe.sh` script removes the log and also ensures that mysqld is able to serve SQL requests, not just that it can open a socket.
The mariadb init script starts mysqld multiple times, so a TCP check will signal startup is complete before the init is actually finished.
- livenessProbe access denied warnings - readinessProbe aborted connection warnings - startupProbe waits for mariadb init to complete - add configurable terminationGracePeriod
feat: apiDB/keycloakDB startup/readiness/liveness probes and startup/shutdown time
tobybellwood
force-pushed
the
prerelease/lagoon_v218
branch
from
April 2, 2024 03:00
658ae91
to
bc27e10
Compare
shreddedbacon
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding chart releases for https://github.com/uselagoon/lagoon/releases/tag/v2.18.0