Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lagoon-core appVersion v2.18.0 #647

Merged
merged 66 commits into from
Apr 2, 2024
Merged

Lagoon-core appVersion v2.18.0 #647

merged 66 commits into from
Apr 2, 2024

Conversation

tobybellwood
Copy link
Member

@tobybellwood tobybellwood commented Feb 23, 2024

shreddedbacon and others added 24 commits July 28, 2023 09:35
While the fill-test-ci-values target's dependency on install-registry
was correctly manipulated by the SKIP_INSTALL_REGISTRY variable, the
install-lagoon-build-deploy target had a hard-coded dependency on
install-registry. The result was that the registry would get installed
multiple times anyway via the fill-test-ci-values target via an indirect
dependency.

Fix that by removing the dependency that install-lagoon-build-deploy has
on install-registry when SKIP_INSTALL_REGISTRY=true.
fix: avoid installing the registry multiple times
chore: modify keycloak healthcheck endpoint for newer keycloak
Set 1.28 as default for tests, also test 1.29
@shreddedbacon
Copy link
Member

To resolve a weird proxy issue with ui/keycloak http 502s when running lagoon in k3d and testing ui functionality, can the core ci-linter-values be extended to include the following section in keycloak on its ingress.

keycloak:
  ingress:
    annotations:
      nginx.ingress.kubernetes.io/proxy-buffer-size: "128k"

tobybellwood and others added 13 commits March 20, 2024 15:27
Using `localhost` and port `3306` forces mysqladmin to connect to `127.0.0.1`
via TCP, instead of via socket. The uselagoon/mariadb images only set a root
password for `localhost`, so the attempt to authenticate via `127.0.0.1` fails.
The current TCP based readiness probe causes an `Aborted connection` log for
each check. Changing it to the `readiness-probe.sh` script removes the log and
also ensures that mysqld is able to serve SQL requests, not just that it can
open a socket.
The mariadb init script starts mysqld multiple times, so a TCP check will
signal startup is complete before the init is actually finished.
- livenessProbe access denied warnings
- readinessProbe aborted connection warnings
- startupProbe waits for mariadb init to complete
- add configurable terminationGracePeriod
feat: apiDB/keycloakDB startup/readiness/liveness probes and startup/shutdown time
@tobybellwood tobybellwood force-pushed the prerelease/lagoon_v218 branch from 658ae91 to bc27e10 Compare April 2, 2024 03:00
@tobybellwood tobybellwood marked this pull request as ready for review April 2, 2024 03:25
Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me

@tobybellwood tobybellwood changed the title Prerelease/lagoon v218 Lagoon-core appVersion v2.18.0 Apr 2, 2024
@tobybellwood tobybellwood merged commit ab9b0c4 into main Apr 2, 2024
17 checks passed
@tobybellwood tobybellwood deleted the prerelease/lagoon_v218 branch April 2, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants